Ensure we always startup with a rustls CryptoProvider (main)
#601
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is now ready for review! |
tnull
force-pushed
the
2025-08-fix-rustls-crypto-provider-main
branch
2 times, most recently
from
0e4507b to
2cdcea3
Compare
|
Putting in draft until we're clear what's going on (give we just saw a CI job where a single test case hit the introduced assert). What a mess. |
tnull
force-pushed
the
2025-08-fix-rustls-crypto-provider-main
branch
from
2cdcea3 to
ac70b2f
Compare
TheBlueMatt
reviewed
Aug 12, 2025
tnull
force-pushed
the
2025-08-fix-rustls-crypto-provider-main
branch
2 times, most recently
from
8ac392d to
4887c75
Compare
The `rustls` library recently introduced this weird behavior where they expect users to, apart from configuring the respective feature, also explictly call `CryptoProvider::install_default`. Otherwise they'd simply panic at runtime whenever the first network call requiring TLS would be made. While we already made a change upstream at `rust-electrum-client`, we also make sure here that we definitely, always, absolutley are sure that we have a `CryptoProvider` set on startup.
tnull
force-pushed
the
2025-08-fix-rustls-crypto-provider-main
branch
from
4887c75 to
1d06c7a
Compare
TheBlueMatt
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #595. (for now)
The
rustlslibrary recently introduced this weird behavior where they expect users to, apart from configuring the respective feature, also explictly callCryptoProvider::install_default. Otherwise they'd simply panic at runtime whenever the first network call requiring TLS would be made. While we already made a change upstream atrust-electrum-client, we also make sure here that we definitely, always, absolutley are sure that we have aCryptoProviderset on startup.